fix: dhis org_units and iaso org_units overlap#261
Merged
Conversation
nazarfil
force-pushed
the
fix-iaso-widget-org-units
branch
2 times, most recently
from
3511cbd to
2ba7cc5
Compare
nazarfil
force-pushed
the
fix-iaso-widget-org-units
branch
from
2ba7cc5 to
76c720d
Compare
yolanfery
reviewed
May 14, 2025
| """Enum for IASO widgets.""" | ||
|
|
||
| FORMS = "IASO_FORMS" | ||
| ORG_UNITS = "IASO_ORG_UNITS" |
Contributor
There was a problem hiding this comment.
Can you please explain, for future reference, why this was an issue ?
Author
There was a problem hiding this comment.
The implementation is parsing the ast and in case of an attribute we do a string compare to map it to correct widget:
So it is either enforce typing with enums and then make sure they are unique, or string check on the prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ORG_UNITS overlap between DHIS2 and IASO